🦋 Changeset detected

Latest commit: ce7f89a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Test results
sse

tool-filter

thanks for the options‑object updates, it’s definitely a nicer api going forward! I had some input on #164 that is referenced here. The original array‑only call to getAllMcpTools was removed in #164 (when tool‑filtering landed) and this PR replaces it with the options object, so existing code like getAllMcpTools(Array.from(servers.values())); i.e., 1‑arg form may fail.

As such, I'm thinking something along the lines of :

// overloads
export function getAllMcpTools(mcpServers: MCPServer[]): Promise<Tool[]>;
export function getAllMcpTools(opts: GetAllMcpToolsOptions): Promise<Tool[]>;

// implementation accepts MCPServer[] | opts
export async function getAllMcpTools(
  mcpServersOrOpts: MCPServer[] | GetAllMcpToolsOptions,
  runContext?: RunContext,
  agent?: Agent,
  convertSchemasToStrict = false,
) {
  const opts = Array.isArray(mcpServersOrOpts)
    ? { mcpServers: mcpServersOrOpts, runContext, agent, convertSchemasToStrict }
    : mcpServersOrOpts;
  // …existing logic…
}

Would you be open to restoring that legacy overload while keeping the new one? Happy to send a quick patch for this part. My quick thought here is that it would restore back‑compat, lets new callers use the options object (potentially the array form can be marked deprecated in a future PR)

thanks for the options‑object updates, it’s definitely a nicer api going forward! I had some input on #164 that is referenced here. The original array‑only call to getAllMcpTools was removed in #164 (when tool‑filtering landed) and this PR replaces it with the options object, so existing code like getAllMcpTools(Array.from(servers.values())); i.e., 1‑arg form may fail.

As such, I'm thinking something along the lines of :

// overloads
export function getAllMcpTools(mcpServers: MCPServer[]): Promise<Tool[]>;
export function getAllMcpTools(opts: GetAllMcpToolsOptions): Promise<Tool[]>;

// implementation accepts MCPServer[] | opts
export async function getAllMcpTools(
  mcpServersOrOpts: MCPServer[] | GetAllMcpToolsOptions,
  runContext?: RunContext,
  agent?: Agent,
  convertSchemasToStrict = false,
) {
  const opts = Array.isArray(mcpServersOrOpts)
    ? { mcpServers: mcpServersOrOpts, runContext, agent, convertSchemasToStrict }
    : mcpServersOrOpts;
  // …existing logic…
}

Would you be open to restoring that legacy overload while keeping the new one? Happy to send a quick patch for this part. My quick thought here is that it would restore back‑compat, lets new callers use the options object (potentially the array form can be marked deprecated in a future PR)

Hi, I've adjusted it. You see if it meets expectations

Thanks for sending this pull request. Overall, the changes look good to me, but could you look into the CI errors?

Thanks for sending this pull request. Overall, the changes look good to me, but could you look into the CI errors?

I'm done. If you need any more adjustments, please feel free to contact me.